module: cache and return effective module exports from linked bindings on first call #5337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
c++
Member
|
LGTM and good catch. The only nit I have is about the commit log: the first line should be <= 50 columns and one or two lines describing the issue and the fix would be appreciated. |
Method `LinkedBinding` must return the same "exports" property of the module as cached, because property can be overridden by an initialization function.
Author
|
@bnoordhuis 👍 done |
Member
|
Thanks, landed in 5c14efb. |
bnoordhuis
pushed a commit
that referenced
this pull request
Feb 20, 2016
Method `LinkedBinding` must return the same "exports" property of the module as cached, because property can be overridden by an initialization function. PR-URL: #5337 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
Shouldn't there be a test? |
Member
|
@thefourtheye It's hard to write a test for. |
Member
|
tagged as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to fix #4771 of #4756
In #4771 the correct
exportsobject goes to the cache, but on the first call ofLinkedBindinganother (precreated)exportsobject returned as result. 😐