Skip to content

tools: update sdwrap.py to use Python3.8 features #54348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
avivkeller wants to merge 2 commits into from
Closed

tools: update sdwrap.py to use Python3.8 features #54348

avivkeller wants to merge 2 commits into from

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Aug 13, 2024

Node.js can't be built without Python 3.8, so this PR updates the sdwrap.py file to use features introduced up until that point.

Ref: #54112

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 13, 2024
@avivkeller avivkeller added the python PRs and issues that require attention from people who are familiar with Python. label Aug 13, 2024
@richardlau
Copy link
Member

richardlau commented Aug 13, 2024

Node.js can't be built without Python 3.8, so this PR updates the sdwrap.py file to use features introduced up until that point.

Ref: #54112

This file is only used on z/OS.
cc @nodejs/platform-zos

anonrig
anonrig reviewed Aug 13, 2024
View reviewed changes
tools/zos/sdwrap.py Outdated

return 0
firstline = True
while (line := args.input.read(72)):
Copy link
Member

@anonrig anonrig Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also updates indentation from 2 to 4.

@avivkeller avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 13, 2024
@avivkeller avivkeller requested a review from anonrig August 13, 2024 16:30
@avivkeller avivkeller closed this Sep 1, 2024
@avivkeller
Copy link
Member Author

avivkeller commented Sep 1, 2024

I'm going to do this in conjunction with some lint changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig Awaiting requested review from anonrig

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avivkeller @richardlau @anonrig @nodejs-github-bot