buffer: improve error handling of buffer.concat #54464
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved TODO to use more proper error code INVALID_ARG_TYPE -> INVALID_ARG_VALUE, it seems better Additionally, when the `list` argument has null or undefined and the `length` argument is undefined, it causes `TypeError: Cannot read properties` error. It has been adjusted to be handled by the INVALID_ARG_VALUE error. Refs: nodejs#19445
nodejs-github-bot
added
buffer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54464 +/- ##
==========================================
- Coverage 87.32% 87.31% -0.01%
==========================================
Files 648 648
Lines 182383 182381 -2
Branches 34991 34986 -5
==========================================
- Hits 159260 159253 -7
- Misses 16384 16385 +1
- Partials 6739 6743 +4
|
Member
|
I'm not sure if this is a breaking change / needs a CIGTM because it's changing an error emitted from a common function. |
anonrig
added
the
semver-major
Contributor
Author
|
/cc @BridgeAR I wonder your opinion, I'm hesitating if it is the right way to resolve the TODO like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved TODO to use more proper error code
INVALID_ARG_TYPE -> INVALID_ARG_VALUE, it seems better
Additionally, when the
listargument has null or undefined and thelengthargument is undefined, it causesTypeError: Cannot read propertieserror.It has been adjusted to be handled by the INVALID_ARG_VALUE error.
And, reflected this changes to tests
Refs: #19445