Skip to content

buffer: throw on invalid encoding in Buffer.from #54586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ronag wants to merge 1 commit into
base: main
Choose a base branch
from
Open

buffer: throw on invalid encoding in Buffer.from #54586

ronag wants to merge 1 commit into from
+6 −3

Conversation

@ronag
Copy link
Member

@ronag ronag commented Aug 27, 2024

Refs: #54533

@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 27, 2024
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Aug 27, 2024
@ronag ronag force-pushed the from-invalid-encoding branch from 2655e59 to 11fe4ff Compare August 27, 2024 05:36
ronag added a commit to nxtedition/node that referenced this pull request Aug 27, 2024
@ronag
buffer: throw on invalid encoding in Buffer.from
11fe4ff 
Refs: nodejs#54533
PR-URL: nodejs#54586
@ronag ronag requested a review from mcollina August 27, 2024 05:36
@ronag
Copy link
Member Author

ronag commented Aug 27, 2024

@nodejs/buffer

@codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.32%. Comparing base (c00ea01) to head (9d335ca).
⚠️ Report is 3280 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54586      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         649      649              
  Lines      182620   182632      +12     
  Branches    35044    35033      -11     
==========================================
- Hits       159484   159481       -3     
- Misses      16397    16419      +22     
+ Partials     6739     6732       -7
Files with missing lines Coverage Δ
lib/buffer.js 96.70% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Aug 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 27, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/61534/

targos
targos reviewed Aug 27, 2024
View reviewed changes
ronag added a commit to nxtedition/node that referenced this pull request Aug 27, 2024
@ronag
buffer: throw on invalid encoding in Buffer.from
3f7fe0c 
Refs: nodejs#54533
PR-URL: nodejs#54586
@ronag ronag force-pushed the from-invalid-encoding branch from 01e19f1 to 3f7fe0c Compare August 27, 2024 13:25
@ronag ronag force-pushed the from-invalid-encoding branch from 3f7fe0c to 9d335ca Compare August 27, 2024 13:26
mcollina
mcollina approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

We should likely fix throughv test. I'll get to it when I can.

@ShenHongFei ShenHongFei mentioned this pull request Aug 30, 2024
Merged
jasnell
jasnell previously approved these changes Aug 31, 2024
View reviewed changes
@jasnell
Copy link
Member

jasnell commented Sep 8, 2024

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 8, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/62166/

@jasnell jasnell dismissed their stale review September 8, 2024 17:24

There are relevant non-flaky CI failures that need to be addressed with this PR

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2025

What's the status here?

@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Nov 8, 2025
@mcollina
Copy link
Member

mcollina commented Nov 8, 2025

Can you push it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos left review comments

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@jasnell jasnell jasnell left review comments

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ronag @nodejs-github-bot @jasnell @aduh95 @mcollina @lpinca @targos @MoLow