Skip to content

[v22.x backport] lib: remove settled dependant signals when they are GCed #55389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geeksilva97 wants to merge 1 commit into from
Closed

[v22.x backport] lib: remove settled dependant signals when they are GCed #55389

geeksilva97 wants to merge 1 commit into from

Conversation

@geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Oct 15, 2024

Backport #55354

@geeksilva97
lib: remove settled dependant signals when they are GCed
35255cd 
PR-URL: nodejs#55354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Oct 15, 2024
@geeksilva97 geeksilva97 mentioned this pull request Oct 15, 2024
Merged
@geeksilva97 geeksilva97 changed the title [v22.x backport] lib: remove settled dependant signals when they are GCed #55388 [v22.x backport] lib: remove settled dependant signals when they are GCed Oct 15, 2024
@avivkeller
Copy link
Member

avivkeller commented Oct 15, 2024

Why? The other PR lands cleanly in the v22.x-staging branch:

$ git cherry-pick 7a7c2b3d0953fa5a8bb69a5d865fce98e0c60669
Auto-merging lib/internal/abort_controller.js
[detached HEAD a60f1c34ad] lib: remove settled dependant signals when they are GCed
 Author: Edigleysson Silva (Edy) <edigleyssonsilva@gmail.com>
 Date: Mon Oct 14 17:33:41 2024 -0300
 2 files changed, 145 insertions(+), 9 deletions(-)
 create mode 100644 test/parallel/test-abortsignal-drop-settled-signals.mjs

@geeksilva97 geeksilva97 deleted the backport-55354-to-v22.x branch May 20, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geeksilva97 @avivkeller @nodejs-github-bot