src: add `--run-from` flag #57592

flakey5 · 2025-03-22T20:19:17Z

This differs from #57523 in that this changes the working directory that the script is executed from.

nodejs-github-bot · 2025-03-22T20:19:22Z

Review requested:

@nodejs/config

Closes nodejs#57489 Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> Co-authored-by: Mert Can Altin <mertgold60@gmail.com> Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>

codecov · 2025-03-22T21:47:08Z

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (4a7d501) to head (6dc382a).
Report is 72 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	40.00%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57592      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         630      630              
  Lines      185149   185065      -84     
  Branches    36235    36222      -13     
==========================================
- Hits       167066   166989      -77     
- Misses      11037    11046       +9     
+ Partials     7046     7030      -16

Files with missing lines	Coverage Δ
src/node_options.cc	`85.36% <100.00%> (+0.01%)`	⬆️
src/node_options.h	`98.88% <ø> (ø)`
src/node_task_runner.cc	`86.70% <40.00%> (-2.69%)`	⬇️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-03-22T22:23:47Z

Is this a duplicate of #57523?

jasnell · 2025-03-22T22:30:56Z

@pmarchini ... it is a simpler alternative to #57523. @flakey5 had started working on it before #57523 was opened based on the discussion in the original issue.

github-actions · 2025-03-22T23:16:22Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

doc/api/cli.md

src/node_options.cc

Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>

doc/api/cli.md

src/node_task_runner.cc

ovflowd

LGTM! Left a minor comment, that might lead to misunderstandings on the expected behavior, but besides that, cool stuff!

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>

mertcanaltin

LGTM 🚀

doc/api/cli.md

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>

doc/api/cli.md

Co-authored-by: James M Snell <jasnell@gmail.com>

jasnell · 2025-03-25T15:32:41Z

I think this change is generally ready to go but due to some ongoing maintenance issues with CI we are restricted from running jenkins CI on this PR just yet. Once that is opened back up we can run CI and get this merged.

github-actions · 2025-04-01T12:00:44Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - src: add `--run-from` flag
   ⚠  - remove debug statement
   ⚠  - Apply suggestions from code review
   ⚠  - update man page
   ⚠  - only allow a directory to be passed in
   ⚠  - Update doc/api/cli.md
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/14195007818

nodejs-github-bot · 2025-04-05T16:55:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66053/

aduh95 · 2025-04-07T22:02:26Z

There's a related test failure:

---
duration_ms: 914.731
exitcode: 1
severity: fail
stack: |-
  Test failure: 'runs script in a custom working directory using --run-from'
  Location: test/parallel/test-node-run.js:226:3
  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + ''
  - '/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/run-script'

ovflowd · 2025-04-11T20:05:32Z

There's a related test failure:

---
duration_ms: 914.731
exitcode: 1
severity: fail
stack: |-
  Test failure: 'runs script in a custom working directory using --run-from'
  Location: test/parallel/test-node-run.js:226:3
  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + ''
  - '/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/run-script'

☝️ @flakey5

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 22, 2025

src: add --run-from flag

1745412

Closes nodejs#57489 Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> Co-authored-by: Mert Can Altin <mertgold60@gmail.com> Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>

flakey5 force-pushed the flakey5/57489 branch from a7d9f86 to 1745412 Compare March 22, 2025 20:34

remove debug statement

390e692

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>

anonrig approved these changes Mar 22, 2025

View reviewed changes

jasnell approved these changes Mar 22, 2025

View reviewed changes

anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 22, 2025

anonrig requested review from GeoffreyBooth, benjamingr and targos March 22, 2025 22:55

anonrig added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 22, 2025

GeoffreyBooth reviewed Mar 23, 2025

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

src/node_options.cc Outdated Show resolved Hide resolved

Apply suggestions from code review

4e28d16

Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>

anonrig approved these changes Mar 23, 2025

View reviewed changes

atlowChemi reviewed Mar 23, 2025

View reviewed changes

doc/api/cli.md Show resolved Hide resolved

ovflowd reviewed Mar 23, 2025

View reviewed changes

src/node_task_runner.cc Show resolved Hide resolved

ovflowd reviewed Mar 23, 2025

View reviewed changes

src/node_task_runner.cc Outdated Show resolved Hide resolved

ovflowd approved these changes Mar 23, 2025

View reviewed changes

update man page

8567c83

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>

mertcanaltin approved these changes Mar 23, 2025

View reviewed changes

atlowChemi approved these changes Mar 23, 2025

View reviewed changes

anonrig approved these changes Mar 23, 2025

View reviewed changes

targos reviewed Mar 24, 2025

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

only allow a directory to be passed in

52f7ca0

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>

anonrig approved these changes Mar 24, 2025

View reviewed changes

jasnell reviewed Mar 24, 2025

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

UlisesGascon approved these changes Mar 25, 2025

View reviewed changes

jasnell reviewed Mar 25, 2025

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

Update doc/api/cli.md

6dc382a

Co-authored-by: James M Snell <jasnell@gmail.com>

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2025

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 1, 2025

This comment was marked as outdated.

Sign in to view

aduh95 removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 2, 2025

This comment was marked as outdated.

Sign in to view

targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2025

Uh oh!

src: add --run-from flag #57592

Are you sure you want to change the base?

src: add --run-from flag #57592

Conversation

flakey5 commented Mar 22, 2025

Uh oh!

nodejs-github-bot commented Mar 22, 2025

Uh oh!

codecov bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pmarchini commented Mar 22, 2025

Uh oh!

jasnell commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

mertcanaltin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasnell commented Mar 25, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 5, 2025

Uh oh!

aduh95 commented Apr 7, 2025

Uh oh!

ovflowd commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

src: add `--run-from` flag #57592

src: add `--run-from` flag #57592

codecov bot commented Mar 22, 2025 •

edited

Loading

jasnell commented Mar 22, 2025 •

edited

Loading