Skip to content

doc: add puskin to collaborators #58308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
May 13, 2025
+3 −0
Merged

doc: add puskin to collaborators #58308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .mailmap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ George Adams <gadams@microsoft.com> <george.adams@uk.ibm.com>
Gerhard Stöbich <deb2001-github@yahoo.de>
Gibson Fahnestock <gibfahn@gmail.com> <gib@uk.ibm.com>
Gil Pedersen <git@gpost.dk> <github@gpost.dk>
Giovanni Bucci <github@puskin.it>
Copy link
Contributor

@aduh95 aduh95 May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why this addition?

Copy link
Member

@marco-ippolito marco-ippolito May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the find-inactive tool was flagging it. I think there is a mismatch between emails

Copy link
Contributor

@aduh95 aduh95 May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, it must the name that mismatches (commit author is Giovanni <github@puskin.it>, while the tool is looking for Giovanni Bucci <github@puskin.it>)

Copy link
Contributor Author

@puskin puskin May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is part of this doc: https://github.com/nodejs/node/blob/main/onboarding.md#exercise-make-a-pull-request-adding-yourself-to-the-readme .

It says:
Run tools/find-inactive-collaborators.mjs. If that command outputs your name, amend the commit to include an addition to the [mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file. See [gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the format of the mailmap file.

Graham Fairweather <xotic750@gmail.com> <xotic750@gmail>
Greg Sabia Tucker <greg@narrowlabs.com> <greg@tucke.rs>
Gregor Martynus <gregor@martynus.net>
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,8 @@ For information about the governance of the Node.js project, see
**Tim Perry** <<pimterry@gmail.com>> (he/him)
* [pmarchini](https://github.com/pmarchini) -
**Pietro Marchini** <<pietro.marchini94@gmail.com>> (he/him)
* [puskin](https://github.com/puskin) -
**Giovanni Bucci** <<github@puskin.it>> (he/him)
* [Qard](https://github.com/Qard) -
**Stephen Belanger** <<admin@stephenbelanger.com>> (he/him)
* [RafaelGSS](https://github.com/RafaelGSS) -
Expand Down
Loading