sqlite: make SQLTagStore.prototype.size a getter
#60246
Merged
+46
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
cjihrig
approved these changes
Oct 13, 2025
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but all of the stylistic changes should really be made separately.
Renegade334
force-pushed
the
sqlite-tagstore-size-getter
branch
from
dabca78 to
3142319
Compare
Member
Author
I'm already half-addressing them de facto with the main change, but these can be spun out if desired. Edit: Spun out the other doc changes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60246 +/- ##
==========================================
+ Coverage 88.04% 88.56% +0.51%
==========================================
Files 703 703
Lines 208260 208259 -1
Branches 40068 40160 +92
==========================================
+ Hits 183360 184438 +1078
+ Misses 16840 15841 -999
+ Partials 8060 7980 -80
🚀 New features to boost your workflow:
|
louwers
approved these changes
Oct 13, 2025
Renegade334
force-pushed
the
sqlite-tagstore-size-getter
branch
2 times, most recently
from
ff66727 to
a2eaaa0
Compare
anonrig
approved these changes
Oct 20, 2025
Renegade334
force-pushed
the
sqlite-tagstore-size-getter
branch
from
a2eaaa0 to
a217a01
Compare
Renegade334
added
request-ci
Drive-by: make callback `args` parameter names consistent
Renegade334
force-pushed
the
sqlite-tagstore-size-getter
branch
from
a217a01 to
4a16146
Compare
Member
Author
|
Rebased for merge conflict. |
anonrig
approved these changes
Nov 18, 2025
cjihrig
approved these changes
Nov 18, 2025
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
All of the info to args renaming makes the diff more involved than it should be for this PR.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Renegade334
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a1f421f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented,
.dband.capacityare getters, and.sizeis a callable method. There's no reason for this inconsistency, so change.sizeto a getter.Drive-by changes while making alterations to the class template: the
FunctionCallbackInfoparameter for SQLTagStore member functions was variably labelledargsorinfo, and wasn't consistent with the header either. Use the canonicalargs.