Skip to content

Conversation

@Botato300
Copy link
Contributor

This PR improves the user experience of the navigation sidebar in the documentation.

Previously, clicking on a module in the sidebar would navigate to its page, but the sidebar
scroll would reset to the top. Now, the sidebar automatically scrolls to keep the selected
module in view, making it easier to navigate between modules without having to scroll manually!

In case it's not clear, here's an example: if you clicked on the “Web Crypto” module, it took you to
its page, but the sidebar scroll returned to the top. Then, to access the next module, “Web Stream”,
you had to manually scroll to its position in the sidebar.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/nodejs-website

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 25, 2025
@AugustinMauroy
Copy link
Member

Cloud you furnish preview (screenshot) of your changes ?

@Botato300
Copy link
Contributor Author

Cloud you furnish preview (screenshot) of your changes ?

I'm sorry, but I didn't understand your question. What do you mean by “Cloud”?

@ovflowd
Copy link
Member

ovflowd commented Oct 28, 2025

I think Augustin meant if you could provide screenshots of your changes (how it looks before and after)

@AugustinMauroy
Copy link
Member

yeah claudio had right typo from my side 😅

@Botato300
Copy link
Contributor Author

I think Augustin meant if you could provide screenshots of your changes (how it looks before and after)

yeah claudio had right typo from my side 😅

Oh, now I understand, of course. Here are two videos:

Before:

before.mp4

After:

after.mp4

@Luisangelgarciahernandez975-prog
Copy link

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Botato300 Botato300 requested a review from aduh95 November 8, 2025 23:57
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly working, and an clear improvement IMO. There's some limitation, such as if the page is loaded in a window smaller than 1025px, then the window is extended, this change does not apply, but that's really a edge-case, just mentioning it here to state that we're intentionally ignoring it :)

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 9, 2025
@aduh95 aduh95 merged commit aa948fd into nodejs:main Nov 23, 2025
18 of 19 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Nov 23, 2025

Landed in aa948fd

flakey5 added a commit to nodejs/doc-kit that referenced this pull request Nov 24, 2025
Mirror to nodejs/node#60410

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
targos pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #60410
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants