-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Improve UX: keep sidebar module visible when navigating docs #60410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
|
Cloud you furnish preview (screenshot) of your changes ? |
I'm sorry, but I didn't understand your question. What do you mean by “Cloud”? |
|
I think Augustin meant if you could provide screenshots of your changes (how it looks before and after) |
|
yeah claudio had right typo from my side 😅 |
Oh, now I understand, of course. Here are two videos: Before: before.mp4After: after.mp4 |
|
Haa?
El mar, 28 de oct. de 2025 11:16 a. m., Botato ***@***.***>
escribió:
… *Botato300* left a comment (nodejs/node#60410)
<#60410 (comment)>
I think Augustin meant if you could provide screenshots of your changes
(how it looks before and after)
yeah claudio had right typo from my side 😅
Oh, now I understand, of course. Here are two videos:
*Before:*
https://github.com/user-attachments/assets/85846ce2-bf9a-4fdb-a3e8-d1c2e8c0a799
*After:*
https://github.com/user-attachments/assets/fce4bbeb-0a84-4244-a82c-f22f065b05c5
—
Reply to this email directly, view it on GitHub
<#60410 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXUHQ7E365DBQWZNQJR7NML3Z6QGJAVCNFSM6AAAAACKGQQHNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJXGU4TKNRWGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aduh95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly working, and an clear improvement IMO. There's some limitation, such as if the page is loaded in a window smaller than 1025px, then the window is extended, this change does not apply, but that's really a edge-case, just mentioning it here to state that we're intentionally ignoring it :)
|
Landed in aa948fd |
Mirror to nodejs/node#60410 Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
PR-URL: #60410 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This PR improves the user experience of the navigation sidebar in the documentation.
Previously, clicking on a module in the sidebar would navigate to its page, but the sidebar
scroll would reset to the top. Now, the sidebar automatically scrolls to keep the selected
module in view, making it easier to navigate between modules without having to scroll manually!
In case it's not clear, here's an example: if you clicked on the “Web Crypto” module, it took you to
its page, but the sidebar scroll returned to the top. Then, to access the next module, “Web Stream”,
you had to manually scroll to its position in the sidebar.