Skip to content

deps: update brotli to 1.2.0 #60540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Nov 21, 2025
Merged

deps: update brotli to 1.2.0 #60540

nodejs-github-bot merged 2 commits into from
Nov 21, 2025

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Nov 2, 2025

This is an automated update of brotli to 1.2.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. zlib Issues and PRs related to the zlib subsystem. labels Nov 2, 2025
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Nov 2, 2025

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added brotli Issues and PRs related to the brotli dependency. needs-ci PRs that need a full CI run. labels Nov 2, 2025
@targos
Copy link
Member

targos commented Nov 2, 2025

Someone needs to update brotli.gyp (there are new source files).

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-brotli branch from f94f1db to 7ef8c87 Compare November 9, 2025 00:38
@targos targos force-pushed the actions/tools-update-brotli branch from 1cd5a5e to 2799c2c Compare November 10, 2025 11:11
@targos targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 10, 2025
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: update brotli to 1.2.0
   ⚠  - fixup: update gyp file
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/19229834114

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Nov 15, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70181/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 15, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-brotli branch from 2799c2c to cc1a67a Compare November 16, 2025 00:39
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Nov 17, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70219/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Nov 17, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70221/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2025
@nodejs-github-bot nodejs-github-bot merged commit 00a8377 into main Nov 21, 2025
54 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Nov 21, 2025

Landed in 00a8377

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-brotli branch November 21, 2025 18:57
@marco-ippolito marco-ippolito mentioned this pull request Nov 24, 2025
Open
targos pushed a commit that referenced this pull request Nov 27, 2025
@nodejs-github-bot @targos
deps: update brotli to 1.2.0
6ccbbe6 
PR-URL: #60540
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. brotli Issues and PRs related to the brotli dependency. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nodejs-github-bot @targos @aduh95