Skip to content

Conversation

@rxiddhi
Copy link
Contributor

@rxiddhi rxiddhi commented Nov 12, 2025

In this PR, I’ve corrected the incorrect term “event handle” to “event handler” in the Utf8Stream drop event description.
Additionally, I made minor grammatical improvements and ensured consistency in language throughout the section for better readability and technical accuracy.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Nov 12, 2025
@rxiddhi rxiddhi changed the title docs(fs): fix incorrect term 'event handle' to 'event handler' and improve consistency docs: correct 'event handle' to 'event handler' in Utf8Stream drop event Nov 12, 2025
@rxiddhi rxiddhi force-pushed the fix-docs branch 2 times, most recently from b0c73e8 to e0e636b Compare November 12, 2025 14:37
Copy link

@DiegoFelipe DiegoFelipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxiddhi
Copy link
Contributor Author

rxiddhi commented Nov 24, 2025

Hey @UlisesGascon ,
This PR is ready from my end - CI checks are all green, and it has an LGTM from the previous review.
Whenever you have a moment, a final approval would be really appreciated, so it can move forward.
Thanks a lot!

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rxiddhi!

I noticed that this change also modifies the line wrapping and adds a \ at the end. We try to keep diffs as minimal as possible for easier review and tracking on releases later on.

Would you mind limiting the change to just replacing handlehandler, without altering the formatting? That would be perfect 🙌

For a visual reference:
image

@rxiddhi
Copy link
Contributor Author

rxiddhi commented Nov 25, 2025

Hey @UlisesGascon!
Thanks for the feedback! I’ve reverted the formatting changes and kept only the typo fix. Please let me know if anything else is needed.😊

@UlisesGascon UlisesGascon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 25, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1b3a64d into nodejs:main Nov 28, 2025
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1b3a64d

@rxiddhi rxiddhi deleted the fix-docs branch November 28, 2025 15:04
targos pushed a commit that referenced this pull request Nov 29, 2025
PR-URL: #60692
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants