Skip to content

build: add support for Visual Studio 2026 #60727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 19, 2025
Merged

build: add support for Visual Studio 2026 #60727

nodejs-github-bot merged 1 commit into from
Nov 19, 2025

Conversation

@targos
Copy link
Member

@targos targos commented Nov 15, 2025

Tested with Parallels Desktop on arm64, so probably not the most common setup.

@nodejs/platform-windows

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Nov 15, 2025
lpinca
lpinca approved these changes Nov 15, 2025
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@targos targos added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70251/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70254/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2025
@nodejs-github-bot nodejs-github-bot merged commit 934d907 into nodejs:main Nov 19, 2025
81 of 84 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2025

Landed in 934d907

@targos targos deleted the vs2026 branch November 19, 2025 16:03
targos added a commit that referenced this pull request Nov 27, 2025
@targos
build: add support for Visual Studio 2026
014852a 
PR-URL: #60727
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos @nodejs-github-bot @lpinca @anonrig @cjihrig @StefanStojanovic