doc: add fullName property to SuiteContext #60762

PaulyBearCoding · 2025-11-17T22:54:33Z

The fullName property exists on SuiteContext at runtime but was not documented.

Tested to verify behavior:

Top-level suite: returns suite name
Nested suite: returns "Parent > Child" format
Implementation confirmed in lib/internal/test_runner/test.js (line 495)

Fixes: #60757

nodejs-github-bot · 2025-11-17T22:54:38Z

Review requested:

@nodejs/test_runner

Ethan-Arrowood

I'm just not sure about the version number otherwise lgtm

doc/api/test.md

Renegade334

LGTM but please address the commit linter error.

Add documentation for the missing fullName property in SuiteContext. This property returns the name of the suite and each of its ancestors, separated by '>'. The property has been available since v22.3.0 but was missing from the documentation. Fixes: nodejs#60757

PaulyBearCoding · 2025-11-19T23:43:52Z

Thanks for the reviews! You're right about the version - I checked PR #53169 and the feature was backported to v20.16.0 (released July 24, 2024), so that's the correct "added" version, not v22.3.0.

doc/api/test.md

- Updated both TestContext#fullName and SuiteContext#fullName - Changed from single version to YAML list format with both v22.3.0 and v20.16.0 - Reflects that fullName was added in v22.3.0 and backported to v20.16.0

PaulyBearCoding · 2025-11-21T22:54:18Z

I have addressed both points:

Version formatting - I've updated to the YAML list format:
```
added:
  - v22.3.0
  - v20.16.0
```
TestContext consistency - I've added the same version metadata to TestContext#fullName to keep the documentation consistent.

Renegade334 · 2025-11-21T22:57:15Z

Can you revert the snapshot changes? Otherwise, all good.

Revert snapshot testing related items back to v22.3.0 as snapshot testing was never backported to v20.x. Only context.fullName was backported to v20.16.0. - Reverted ## Snapshot testing to v22.3.0 - Reverted ## snapshot to v22.3.0 - Reverted snapshot.setDefaultSnapshotSerializers to v22.3.0 - Reverted snapshot.setResolveSnapshotPath to v22.3.0 - Reverted context.assert.snapshot to v22.3.0 - Kept fullName properties with YAML list format (v22.3.0 and v20.16.0)

PaulyBearCoding · 2025-11-22T01:50:07Z

I have reverted the snapshot testing changes as requested.

The snapshot-related version metadata has been restored to v22.3.0, while the fullName properties (both TestContext and SuiteContext) now use the YAML list format with both v22.3.0 and v20.16.0.

Renegade334

Thanks!

PaulyBearCoding · 2025-11-23T05:15:09Z

CI fixed - ready for re-run

atlowChemi · 2025-11-23T18:28:45Z

@PaulyBearCoding the CI is still failing due to the commit message (line-length: Line should be <= 72 columns.)

Please reword the commit to address this issue 🙂

atlowChemi

LGTM, other than commit message issue

PaulyBearCoding · 2025-11-23T19:56:31Z

It should be good to go now.

aduh95 · 2025-11-23T22:44:21Z

Does the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. still stands?

Renegade334 · 2025-11-23T22:57:38Z

It features post-v20 version info, so yes AFAIA?

aduh95 · 2025-11-23T23:41:27Z

It features post-v20 version info, so yes AFAIA?

The PR is documenting that the changes have landed on 20.16.0, so either that’s wrong and we should amend this PR before landing, either that’s true and it’s worth backporting. Or am I missing something?

Renegade334 · 2025-11-23T23:48:27Z

backport-requested would be the more accurate label, aye.

nodejs-github-bot · 2025-11-25T19:34:21Z

Landed in 9098093

Add documentation for the missing fullName property in SuiteContext. This property returns the name of the suite and each of its ancestors, separated by '>'. The property has been available since v22.3.0 but was missing from the documentation. Fixes: #60757 PR-URL: #60762 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Nov 17, 2025

Ethan-Arrowood reviewed Nov 18, 2025

View reviewed changes

doc/api/test.md Outdated Show resolved Hide resolved

Renegade334 approved these changes Nov 18, 2025

View reviewed changes

PaulyBearCoding force-pushed the doc-suitecontext-fullname branch from 43e96d5 to 4a9adfe Compare November 19, 2025 23:43

Ethan-Arrowood approved these changes Nov 21, 2025

View reviewed changes

Renegade334 requested changes Nov 21, 2025

View reviewed changes

doc/api/test.md Outdated Show resolved Hide resolved

doc/api/test.md Show resolved Hide resolved

doc: use YAML list format for fullName version metadata

bf72fa6

- Updated both TestContext#fullName and SuiteContext#fullName - Changed from single version to YAML list format with both v22.3.0 and v20.16.0 - Reflects that fullName was added in v22.3.0 and backported to v20.16.0

Renegade334 approved these changes Nov 22, 2025

View reviewed changes

Renegade334 added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Nov 22, 2025

anonrig approved these changes Nov 23, 2025

View reviewed changes

PaulyBearCoding force-pushed the doc-suitecontext-fullname branch from 755c51a to 6e994fe Compare November 23, 2025 05:11

atlowChemi approved these changes Nov 23, 2025

View reviewed changes

PaulyBearCoding force-pushed the doc-suitecontext-fullname branch from 6e994fe to 3804dcc Compare November 23, 2025 19:53

Renegade334 approved these changes Nov 23, 2025

View reviewed changes

Renegade334 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2025

nodejs-github-bot merged commit 9098093 into nodejs:main Nov 25, 2025
27 checks passed

Uh oh!

doc: add fullName property to SuiteContext #60762

doc: add fullName property to SuiteContext #60762

Conversation

PaulyBearCoding commented Nov 17, 2025

Uh oh!

nodejs-github-bot commented Nov 17, 2025

Uh oh!

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Renegade334 left a comment

Choose a reason for hiding this comment

Uh oh!

PaulyBearCoding commented Nov 19, 2025

Uh oh!

Uh oh!

Uh oh!

PaulyBearCoding commented Nov 21, 2025

Uh oh!

Renegade334 commented Nov 21, 2025

Uh oh!

PaulyBearCoding commented Nov 22, 2025

Uh oh!

Renegade334 left a comment

Choose a reason for hiding this comment

Uh oh!

PaulyBearCoding commented Nov 23, 2025

Uh oh!

atlowChemi commented Nov 23, 2025

Uh oh!

atlowChemi left a comment

Choose a reason for hiding this comment

Uh oh!

PaulyBearCoding commented Nov 23, 2025

Uh oh!

aduh95 commented Nov 23, 2025

Uh oh!

Renegade334 commented Nov 23, 2025

Uh oh!

aduh95 commented Nov 23, 2025

Uh oh!

Renegade334 commented Nov 23, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants