Skip to content

[v25.x] Revert "doc, assert: correct order of changes entries" #60774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 1 commit into from
Closed

[v25.x] Revert "doc, assert: correct order of changes entries" #60774

targos wants to merge 1 commit into from
+0 −6

Conversation

@targos
Copy link
Member

@targos targos commented Nov 18, 2025

This reverts commit 8a6de38.

The documented change is semver-major and never landed on v25.x.

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. labels Nov 18, 2025
@targos targos changed the title Revert "doc, assert: correct order of changes entries" [v25.x] Revert "doc, assert: correct order of changes entries" Nov 18, 2025
@targos targos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 18, 2025
@aduh95
Copy link
Contributor

aduh95 commented Nov 18, 2025

Note that main also needs fixing:

node/doc/api/assert.md

Lines 345 to 347 in 0b6ae6d

- version: v25.1.0
pr-url: https://github.com/nodejs/node/pull/58849
description: Message may now be a `printf`-like format string or function.

@meixg meixg added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 19, 2025
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2025
targos added a commit that referenced this pull request Nov 25, 2025
@targos
Revert "doc, assert: correct order of changes entries"
c1cec7a 
This reverts commit 8a6de38.

PR-URL: #60774
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@targos
Copy link
Member Author

targos commented Nov 25, 2025

Landed in c1cec7a

@targos targos closed this Nov 25, 2025
@targos targos deleted the revert-doc-v25 branch November 25, 2025 08:38
targos added a commit to targos/node that referenced this pull request Nov 25, 2025
@targos
doc: restore REPLACEME on assert change
730aae5 
The change was semver-major and didn't land on v25.x

Refs: nodejs#60774
@targos targos mentioned this pull request Nov 25, 2025
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 27, 2025
@targos
doc: restore REPLACEME on assert change
0177491 
The change was semver-major and didn't land on v25.x

Refs: #60774
PR-URL: #60848
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@meixg meixg meixg approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

+1 more reviewer

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@targos @aduh95 @lpinca @richardlau @Renegade334 @meixg @aymen94 @jakecastelli @nodejs-github-bot