Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Nov 23, 2025

@panva panva added confirmed-bug Issues with confirmed bugs. crypto Issues and PRs related to the crypto subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. webcrypto labels Nov 23, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 23, 2025
@nodejs-github-bot
Copy link
Collaborator

@panva
Copy link
Member Author

panva commented Nov 23, 2025

cc @nodejs/tsc for semver-major PRs that contain breaking changes and should be released in the next major version.

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (d255fc7) to head (a41d624).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60830      +/-   ##
==========================================
- Coverage   88.55%   88.55%   -0.01%     
==========================================
  Files         703      703              
  Lines      208259   208259              
  Branches    40164    40175      +11     
==========================================
- Hits       184432   184416      -16     
- Misses      15823    15857      +34     
+ Partials     8004     7986      -18     
Files with missing lines Coverage Δ
lib/internal/crypto/webcrypto.js 96.37% <100.00%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2025
@panva
Copy link
Member Author

panva commented Nov 29, 2025

ping @nodejs/tsc for semver-major PRs that contain breaking changes and should be released in the next major version.

@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/60830
✔  Done loading data for nodejs/node/pull/60830
----------------------------------- PR info ------------------------------------
Title      crypto: fix DOMException name for non-extractable key error (#60830)
Author     Filip Skokan <panva.ip@gmail.com> (@panva)
Branch     panva:fix-domexception-name -> nodejs:main
Labels     confirmed-bug, crypto, semver-major, author ready, needs-ci, webcrypto
Commits    1
 - crypto: fix DOMException name for non-extractable key error
Committers 1
 - Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/60830
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60830
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 23 Nov 2025 18:44:17 GMT
   ✔  Approvals: 5
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/60830#pullrequestreview-3497965387
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60830#pullrequestreview-3497974513
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/60830#pullrequestreview-3499188192
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60830#pullrequestreview-3500727821
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/60830#pullrequestreview-3520807268
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-11-23T18:45:39Z: https://ci.nodejs.org/job/node-test-pull-request/70290/
- Querying data for job/node-test-pull-request/70290/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/19788567862

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 29, 2025
@panva panva removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 29, 2025
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2025
@nodejs-github-bot nodejs-github-bot merged commit 94cd600 into nodejs:main Nov 30, 2025
95 of 105 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 94cd600

@panva panva deleted the fix-domexception-name branch December 1, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. confirmed-bug Issues with confirmed bugs. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants