-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
crypto: fix DOMException name for non-extractable key error #60830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
|
cc @nodejs/tsc for
semver-major
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60830 +/- ##
==========================================
- Coverage 88.55% 88.55% -0.01%
==========================================
Files 703 703
Lines 208259 208259
Branches 40164 40175 +11
==========================================
- Hits 184432 184416 -16
- Misses 15823 15857 +34
+ Partials 8004 7986 -18
🚀 New features to boost your workflow:
|
|
ping @nodejs/tsc for
semver-major
|
Commit Queue failed- Loading data for nodejs/node/pull/60830 ✔ Done loading data for nodejs/node/pull/60830 ----------------------------------- PR info ------------------------------------ Title crypto: fix DOMException name for non-extractable key error (#60830) Author Filip Skokan <panva.ip@gmail.com> (@panva) Branch panva:fix-domexception-name -> nodejs:main Labels confirmed-bug, crypto, semver-major, author ready, needs-ci, webcrypto Commits 1 - crypto: fix DOMException name for non-extractable key error Committers 1 - Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60830 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60830 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 23 Nov 2025 18:44:17 GMT ✔ Approvals: 5 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/60830#pullrequestreview-3497965387 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60830#pullrequestreview-3497974513 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/60830#pullrequestreview-3499188192 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60830#pullrequestreview-3500727821 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/60830#pullrequestreview-3520807268 ✘ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-11-23T18:45:39Z: https://ci.nodejs.org/job/node-test-pull-request/70290/ - Querying data for job/node-test-pull-request/70290/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/19788567862 |
|
Landed in 94cd600 |
As per step 7 in https://w3c.github.io/webcrypto/#SubtleCrypto-method-exportKey