Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Nov 27, 2025

I'm preparing an update of cpplint.py and it flagged these.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Nov 27, 2025
@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2025
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (6706b22) to head (74456f5).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60868      +/-   ##
==========================================
+ Coverage   88.54%   88.56%   +0.01%     
==========================================
  Files         703      703              
  Lines      208262   208262              
  Branches    40170    40171       +1     
==========================================
+ Hits       184408   184448      +40     
+ Misses      15861    15824      -37     
+ Partials     7993     7990       -3     
Files with missing lines Coverage Δ
src/node_http2.cc 82.04% <100.00%> (+0.09%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 27, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit d1ab5ef into nodejs:main Nov 29, 2025
83 of 85 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d1ab5ef

targos added a commit that referenced this pull request Nov 29, 2025
PR-URL: #60868
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.