Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Nov 27, 2025

To prepare for eslint-plugin-jsdoc update.

Refs: #60535

To prepare for eslint-plugin-jsdoc update.

Refs: nodejs#60535
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. web streams labels Nov 27, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (634dc26) to head (f4369f4).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60870      +/-   ##
==========================================
+ Coverage   88.54%   88.56%   +0.02%     
==========================================
  Files         703      703              
  Lines      208239   208238       -1     
  Branches    40160    40158       -2     
==========================================
+ Hits       184395   184436      +41     
+ Misses      15860    15817      -43     
- Partials     7984     7985       +1     
Files with missing lines Coverage Δ
lib/fs.js 98.18% <100.00%> (ø)
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/webstreams/adapters.js 85.57% <100.00%> (-0.02%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

targos added a commit that referenced this pull request Nov 30, 2025
To prepare for eslint-plugin-jsdoc update.

Refs: #60535
PR-URL: #60870
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos
Copy link
Member Author

targos commented Nov 30, 2025

Landed in 10837e3

@targos targos closed this Nov 30, 2025
@targos targos deleted the jsdoc branch November 30, 2025 18:15
targos added a commit that referenced this pull request Dec 5, 2025
To prepare for eslint-plugin-jsdoc update.

Refs: #60535
PR-URL: #60870
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. quic Issues and PRs related to the QUIC implementation / HTTP/3. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants