Skip to content

doc: correct spelling in BUILDING.md #60875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 29, 2025
Merged

doc: correct spelling in BUILDING.md #60875

nodejs-github-bot merged 1 commit into from
Nov 29, 2025

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 27, 2025

Really just testing another github-bot dependency update and making sure it still labels new PRs. But this is a legit fix too.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 27, 2025

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 27, 2025
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 27, 2025
@richardlau
Copy link
Member

richardlau commented Nov 27, 2025

Technically the commit message should start with an imperative verb

node/doc/contributing/pull-requests.md

Lines 164 to 172 in 08d966c

1. The first line should:
* contain a short description of the change (preferably 50 characters or
less, and no more than 72 characters)
* be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.

@Trott
Copy link
Member Author

Trott commented Nov 27, 2025 •
edited
Loading

Technically the commit message should start with an imperative verb

OMG, I'm that far disconnected from the project these days that I did this. I thought I was the only one that cared about that. 😆

Fixing and force-pushing to my branch....

@Trott Trott changed the title doc: spelling correction in BUILDING.md doc: correct spelling in BUILDING.md Nov 27, 2025
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2025
@deokjinkim deokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit e42c6c8 into nodejs:main Nov 29, 2025
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 29, 2025

Landed in e42c6c8

aduh95 pushed a commit that referenced this pull request Nov 30, 2025
@Trott @aduh95
doc: correct spelling in BUILDING.md
a3fcf9e 
PR-URL: #60875
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@sxa sxa sxa approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Trott @nodejs-github-bot @richardlau @panva @lpinca @cjihrig @UlisesGascon @sxa @RafaelGSS @deokjinkim