Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Dec 11, 2025

#60850 updated a target that never runs with Debug builds, this broke the ability for CI to upload daily wpt.fyi reports

This PR reverts the test-wpt-report target to use NODE which is what CI consistently sets

Refs: https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1765400746909869

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Dec 11, 2025
@panva panva changed the title build: update test-wpt-report to use NODE instead OUT_NODE build: update test-wpt-report to use NODE instead of OUT_NODE Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.02%. Comparing base (e28656a) to head (2d99ee4).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61024      +/-   ##
==========================================
- Coverage   88.51%   88.02%   -0.50%     
==========================================
  Files         703      703              
  Lines      208496   208522      +26     
  Branches    40213    40128      -85     
==========================================
- Hits       184555   183548    -1007     
- Misses      15955    16935     +980     
- Partials     7986     8039      +53     

see 112 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2025
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 41c507f into nodejs:main Dec 20, 2025
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 41c507f

@panva panva deleted the fix-nightly-wpt branch December 20, 2025 19:46
MatricalDefunkt pushed a commit to MatricalDefunkt/node that referenced this pull request Dec 22, 2025
PR-URL: nodejs#61024
Refs: https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1765400746909869
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants