test: remove unneccessary repl magic_mode tests

[dario-piotrowicz]

REPL magic mode has been fully removed in 2018 (#19187) there are however a couple of tests that still test magic_mode. These tests are completely redundant since they are basically simply duplicating equivalent tests of sloppy mode (since that's the mode that REPL will use when it encounters the unrecognized magic mode flag). That's why I'm removing them here.

[dario-piotrowicz]

This test is effectively a duplicate of

node/test/parallel/test-repl-mode.js

Lines 21 to 30 in 8b14c72

	function testSloppyMode() {
	const { input, output } = startNewREPLServer({ replMode: repl.REPL_MODE_SLOPPY, terminal: false, prompt: '> ' });
	input.emit('data', 'x = 3\n');
	assert.strictEqual(output.accumulator, '> 3\n> ');
	output.accumulator = '';
	input.emit('data', 'let y = 3\n');
	assert.strictEqual(output.accumulator, 'undefined\n> ');
	}

[dario-piotrowicz]

This test is effectively a duplicate of

node/test/parallel/test-repl-underscore.js

Lines 16 to 50 in 8b14c72

	function testSloppyMode() {
	const { replServer, output } = startNewREPLServer({
	prompt: testingReplPrompt,
	mode: repl.REPL_MODE_SLOPPY,
	});
	// Cannot use `let` in sloppy mode
	replServer.write(`_; // initial value undefined
	var x = 10; // evaluates to undefined
	_; // still undefined
	y = 10; // evaluates to 10
	_; // 10 from last eval
	_ = 20; // explicitly set to 20
	_; // 20 from user input
	_ = 30; // make sure we can set it twice and no prompt
	_; // 30 from user input
	y = 40; // make sure eval doesn't change _
	_; // remains 30 from user input
	`);
	assertOutput(output, [
	'undefined',
	'undefined',
	'undefined',
	'10',
	'10',
	'Expression assignment to _ now disabled.',
	'20',
	'20',
	'30',
	'30',
	'40',
	'30',
	]);
	}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (4f24aff) to head (b262504).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61053   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         703      703           
  Lines      208546   208546           
  Branches    40217    40222    +5     
=======================================
  Hits       184634   184634           
+ Misses      15926    15913   -13     
- Partials     7986     7999   +13     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70517/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70531/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70536/

[aduh95]

@dario-piotrowicz please do not repeatedly add the request-ci Add this label to start a Jenkins CI on a PR. label, that restarts all the Jankins jobs, risking oversubscribing our Jenkins infra and increasing the chance of landing a change introducing more flakiness.
Instead, you can add the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label and wait for someone to check the CI result and chose to resume only if the failure is indeed a fluke.

[nodejs-github-bot]

Landed in e5b6f89