doc: correct description of error.stack accessor behavior
#61090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renegade334
added
dont-land-on-v20.x
nodejs-github-bot
added
doc
Contributor
|
Should we mention https://github.com/tc39/proposal-error-stack-accessor, which I think is what triggered the change in V8? |
Member
Author
|
@ljharb reckon this is mature enough to reference on our side? |
lpinca
approved these changes
Dec 24, 2025
|
|
||
| `error.stack` is a getter/setter for a hidden internal property which is only | ||
| present on builtin `Error` objects (those for which [`Error.isError`][] returns | ||
| true). If `error` is not a builtin error object, then the `error.stack` getter |
Member
There was a problem hiding this comment.
Suggested change
| true). If `error` is not a builtin error object, then the `error.stack` getter | |
| `true`). If `error` is not a builtin error object, then the `error.stack` getter |
Member
|
I think it’s probably fine, but still best to wait for stage 2.7 at least. |
legendecas
reviewed
Jan 2, 2026
legendecas
approved these changes
Jan 3, 2026
Member
|
I think this describes the status quo. This does not need to wait or be blocked by https://github.com/tc39/proposal-error-stack-accessor. |
legendecas
added
lts-watch-v22.x
Renegade334
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a327288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing description in errors.md is outdated as of v21.x:
thisvalue passed to the getter/setter is not a native error.This behaviour isn't mentioned in V8/Chromium documentation nor MDN, so it's worth spelling out here.
Error.isError()doesn't exist in v22.x, so this will need a specific PR referencingutil.types.isNativeError()instead.Refs: #60862