Skip to content

Conversation

@Tseian
Copy link

@Tseian Tseian commented Dec 24, 2025

#60951

Description

Improves the error message when process.cwd() failed by adding prefix err message 'process.cwd failed with error' if call uv_cwd failed

Before

Error: ENOENT: no such file or directory, uv_cwd

After

ENOENT: process.cwd failed with error no such file or directory, uv_cwd

Changes

  • src/node_process_methods.cc

Test

  • test/known_issues/test-cwd-enoent-file.js
  • test/parallel/test-cwd-enoent-improved-message.js

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (732ab9d) to head (6dfc827).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61164      +/-   ##
==========================================
- Coverage   92.22%   88.52%   -3.71%     
==========================================
  Files         343      703     +360     
  Lines      139240   208587   +69347     
  Branches    22253    40220   +17967     
==========================================
+ Hits       128413   184647   +56234     
- Misses      10600    15958    +5358     
- Partials      227     7982    +7755     
Files with missing lines Coverage Δ
src/node_process_methods.cc 88.74% <100.00%> (ø)

... and 477 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tseian
Copy link
Author

Tseian commented Dec 24, 2025

@theanarkh @joyeecheung Please trigger the ci to check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants