doc: document error event on readline InterfaceConstructor #61170
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aims to document the error event introduced by cb3020d in v16.0.0. Fixes: nodejs#58289
nodejs-github-bot
added
doc
avivkeller
approved these changes
Dec 25, 2025
Member
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
Note this also fixes #61037. I've updated the description accordingly
lpinca
approved these changes
Dec 25, 2025
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
cjihrig
approved these changes
Dec 26, 2025
aduh95
reviewed
Dec 26, 2025
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Dec 27, 2025
aduh95
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61170 ✔ Done loading data for nodejs/node/pull/61170 ----------------------------------- PR info ------------------------------------ Title doc: document error event on readline InterfaceConstructor (#61170) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Xstoudi:doc/readline-error -> nodejs:main Labels doc, readline, author ready Commits 3 - doc: document error event on readline InterfaceConstructor - Apply suggestions from code review - Update doc/api/readline.md Committers 2 - Xavier Stouder <xavier@stouder.io> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/61170 Fixes: https://github.com/nodejs/node/issues/58289 Fixes: https://github.com/nodejs/node/issues/61037 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61170 Fixes: https://github.com/nodejs/node/issues/58289 Fixes: https://github.com/nodejs/node/issues/61037 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 25 Dec 2025 00:52:02 GMT ✔ Approvals: 4 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61170#pullrequestreview-3612394364 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61170#pullrequestreview-3612444725 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61170#pullrequestreview-3613700448 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61170#pullrequestreview-3614366529 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61170 From https://github.com/nodejs/node * branch refs/pull/61170/merge -> FETCH_HEAD ✔ Fetched commits as ed47077736f6..9ecc40f56111 -------------------------------------------------------------------------------- [main 742de1129b] doc: document error event on readline InterfaceConstructor Author: Xavier Stouder <xavier@stouder.io> Date: Tue Dec 23 21:21:13 2025 +0100 1 file changed, 13 insertions(+) [main 504a43b431] Apply suggestions from code review Author: Xavier Stouder <xavier@stouder.io> Date: Fri Dec 26 08:35:50 2025 +0100 1 file changed, 1 insertion(+), 4 deletions(-) [main 90213c8eb7] Update doc/api/readline.md Author: Xavier Stouder <xavier@stouder.io> Date: Sat Dec 27 12:16:27 2025 +0100 1 file changed, 2 insertions(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. (node:2324) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/6) Executing: git node land --amend --yes ⚠ Found Fixes: https://github.com/nodejs/node/issues/58289, skipping.. --------------------------------- New Message ---------------------------------- doc: document error event on readline InterfaceConstructorhttps://github.com/nodejs/node/actions/runs/20541519780 |
aduh95
added
commit-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to document the
'error'event introduced by cb3020d in v16.0.0.Fixes: #58289
Fixes: #61037