Skip to content

deps: V8: cherry-pick 64b36b441179#61798

Closed
Dhruv-Garg79 wants to merge 2 commits intonodejs:v24.x-stagingfrom
Dhruv-Garg79:backport-v24.x-cherry-pick-64b36b4
Closed

deps: V8: cherry-pick 64b36b441179#61798
Dhruv-Garg79 wants to merge 2 commits intonodejs:v24.x-stagingfrom
Dhruv-Garg79:backport-v24.x-cherry-pick-64b36b4

Conversation

@Dhruv-Garg79
Copy link

Original commit message:

optimize ascii fast path in WriteUtf8V2

Change-Id: If28168cb4395b953d0ec642ef4fc618ce963dbcd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124103
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Erik Corry <erikcorry@chromium.org>
Reviewed-by: Erik Corry <erikcorry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103542}

Refs: v8/v8@64b36b4

This backport will fix this issue: #60719

Original commit message:

    optimize ascii fast path in WriteUtf8V2

    Change-Id: If28168cb4395b953d0ec642ef4fc618ce963dbcd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124103
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Erik Corry <erikcorry@chromium.org>
    Reviewed-by: Erik Corry <erikcorry@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103542}

Refs: v8/v8@64b36b4
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Feb 13, 2026
@targos
Copy link
Member

targos commented Feb 13, 2026

This is a "duplicate" of #61712, which landed on main and has the lts-watch-v24.x label. I verified it cherry-picks cleanly to the staging branch.

@Dhruv-Garg79
Copy link
Author

Ahh damn... There was no update on the issue, so I thought no one picked this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants