Skip to content

src,tools: allow utf-8 in built-in js source code #6200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnoordhuis wants to merge 3 commits into from
Closed

src,tools: allow utf-8 in built-in js source code #6200

bnoordhuis wants to merge 3 commits into from

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Apr 14, 2016 •
edited
Loading

@bnoordhuis
src,tools: allow utf-8 in built-in js source code
480add8 
PR-URL: nodejs#5418
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src,tools: drop nul byte from built-in source code
08ef1e9 
PR-URL: nodejs#5418
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src,tools: remove null sentinel from source array
3322b3f 
PR-URL: nodejs#5418
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis bnoordhuis mentioned this pull request Apr 14, 2016
Merged
@mscdex mscdex added tools Issues and PRs related to the tools directory. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 14, 2016
@bnoordhuis
Copy link
Member Author

bnoordhuis commented Apr 14, 2016

CI is green except for a flake on one of the ARM buildbots (link):

not ok 56 test-http-header-response-splitting.js
# TIMEOUT
  ---
  duration_ms: 120.69

@MylesBorins MylesBorins self-assigned this Apr 14, 2016
@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 14, 2016

landed in staging as 9a33f43...74768c4

@MylesBorins MylesBorins removed their assignment Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bnoordhuis @MylesBorins @mscdex