test: test commit for nodejs-github-bot #6674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
wip
Member
|
@Fishrock123 @jbergstroem highfive (see below) |
Member
|
Ok, I'll add progress to more jobs. For now it will be pass/fail but I'll add as we move forward. |
Member
|
Also, I've added the boolean flag (default false) to test-pr and test-commit, meaning all jobs should inherit from it. |
Contributor
Author
|
Looks like the linter aborted here, @jbergstroem is it possible to make Jenkins send "build aborted" on abort rather than "errors found"? |
Contributor
Author
Contributor
Author
|
@jbergstroem hmm, strange, it don't update on new CI? All the links seems to be linked to different runs too. |
Member
|
@Fishrock123 we've got some issues figuring out the correct SHA to provide to the bot, related to rebasing. |
Contributor
Author
|
Testing with no rebasing: https://ci.nodejs.org/job/node-test-pull-request/2584/ edit: no dice, maybe it's disabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do Not Merge
Tracking testing issue for nodejs/github-bot#35
Current status at nodejs/github-bot#35 (comment)