tools: disallow deprecated define getter/setter

.eslintrc

@@ -94,6 +94,7 @@ rules:
   assert-fail-single-argument: 2
   new-with-error: [2, "Error", "RangeError", "TypeError", "SyntaxError", "ReferenceError"]
   no-deepEqual: 2
+  no-definegetter-definesetter: 2
 
 # Global scoped method and vars
 globals:

test/parallel/test-util-inspect.js

@@ -205,9 +205,14 @@ assert.equal(util.inspect(value), '{ a: [Circular] }');
 
 // Array with dynamic properties
 value = [1, 2, 3];
-value.__defineGetter__('growingLength', function() {
-  this.push(true); return this.length;
-});
+Object.defineProperty(
+  value,
+  'growingLength',
+  {
+    enumerable: true,
+    get: () => { this.push(true); return this.length; }
+  }
+);
 assert.equal(util.inspect(value), '[ 1, 2, 3, growingLength: [Getter] ]');
 
 // Function with properties

tools/eslint-rules/no-definegetter-definesetter.js

@@ -0,0 +1,32 @@
+/**
+ * @fileoverview Rule to flag usage of __defineGetter__ and __defineSetter__
+ * @author Rich Trott
+ */
+
+'use strict';
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = {
+  create: function(context) {
+    const disallowed = ['__defineGetter__', '__defineSetter__'];
+
+    return {
+      MemberExpression: function(node) {
+        var prop;
+        if (node.property) {
+          if (node.property.type === 'Identifier' && !node.computed) {
+            prop = node.property.name;
+          } else if (node.property.type === 'Literal') {
+            prop = node.property.value;
+          }
+          if (disallowed.includes(prop)) {
+            context.report(node, `The ${prop} property is deprecated.`);
+          }
+        }
+      }
+    };
+  }
+};