Skip to content

test: make test-child-process-fork-net more robust #7033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: make test-child-process-fork-net more robust #7033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/parallel/test-child-process-fork-net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
const assert = require('assert');
const common = require('../common');
require('../common');
const fork = require('child_process').fork;
const net = require('net');

Expand Down Expand Up @@ -91,7 +91,7 @@ if (process.argv[2] === 'child') {
console.log('PARENT: server listening');
child.send({what: 'server'}, server);
});
server.listen(common.PORT);
server.listen(0);

// handle client messages
var messageHandlers = function(msg) {
Expand All @@ -100,7 +100,7 @@ if (process.argv[2] === 'child') {
// make connections
var socket;
for (var i = 0; i < 4; i++) {
socket = net.connect(common.PORT, function() {
socket = net.connect(server.address().port, function() {
console.log('CLIENT: connected');
});
socket.on('close', function() {
Expand Down Expand Up @@ -143,9 +143,9 @@ if (process.argv[2] === 'child') {
//
// An isolated test for this would be lovely, but for now, this
// will have to do.
server.listen(common.PORT + 1, function() {
server.listen(0, function() {
console.error('testSocket, listening');
var connect = net.connect(common.PORT + 1);
var connect = net.connect(server.address().port);
var store = '';
connect.on('data', function(chunk) {
store += chunk;
Expand Down