test: accept EPROTONOSUPPORT ipv6 error #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Contributor
|
In the same vein you could add ESOCKTNOSUP. |
The IPv6 test in parallel/test-dgram-error-message-address may fail when the host system has disabled IPv6, as is the case on our FreeBSD machines. The test already accepted EAFNOSUPPORT as of commit 5ba307a, now make it accept EPROTONOSUPPORT as well. I'm not exactly thrilled by the profusion of error codes but they are all legitimate. PR-URL: nodejs#733 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
force-pushed
the
fix-fbsd-test
branch
from
d7d4ba4 to
62512bb
Compare
Member
Author
|
@piscisaureus Not until a test starts failing with that error. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPv6 test in parallel/test-dgram-error-message-address may fail
when the host system has disabled IPv6, as is the case on our FreeBSD
machines. The test already accepted EAFNOSUPPORT as of commit 5ba307a,
now make it accept EPROTONOSUPPORT as well.
I'm not exactly thrilled by the profusion of error codes but they are
all legitimate.
R=@indutny?
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/150/