test: split test-crypto-timing-safe-equal #8202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move non-intensive parts of test-crypto-timing-safe-equal from sequential to parallel. The test in sequential is marked as flaky due to the intensive part of the test. This will allow the non-intensive part to register as a genuine failure if something breaks it.
Trott
added
crypto
| @@ -0,0 +1,35 @@ | |||
| // Flags: --allow_natives_syntax | |||
Member
Author
There was a problem hiding this comment.
Whoops, it's not. Leftover from the test I was extracting it from. I've removed it. Thanks!
Member
|
LGTM |
Member
Author
|
Closing as revert of the commit that added this test in the first place is imminent... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test crypto
Description of change
Move non-intensive parts of test-crypto-timing-safe-equal from
sequential to parallel.
The test in sequential is marked as flaky due to the intensive part of
the test. This will allow the non-intensive part to register as a
genuine failure if something breaks it.