WIP: test-stdio-closed troubleshooting #8414
Conversation
mscdex
added
test
src/node.cc
Outdated
| if (fd != open("/dev/null", O_RDWR)) | ||
| if (errno != EBADF) | ||
| ABORT(); | ||
| open("/dev/null", O_RDWR); |
There was a problem hiding this comment.
I think we should make sure that this open return current loop fd (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO).
There was a problem hiding this comment.
Thanks for the feedback. Yes, no doubt. This is not intended to be merged. That's what the WIP (work in progress) and the in progress label are meant to indicate. Trying some non-intuitive (and quite possibly ignorant) things to try to figure out why this bit of code seems to be not working (or perhaps the associated test is what is not working) on AIX but working on all the other POSIX systems we test on.
There was a problem hiding this comment.
I guess this related to "AIX: parallel/test-stdio-closed #8375".
On AIX, I remember that there is a kernel parameter regarding max number of pseudo terminals allowed in the system. I suspect the issue is somehow related to the kernel parameter. Need to check the "errno" when the test fails.
EDIT: seems not directly related to pty because the path to open is "/dev/null".
test/parallel/test-stdio-closed.js
Outdated
| process.exit(41); | ||
| }); | ||
|
|
||
| process.stderr.on('err', (err) => { |
|
Closing for now. |
|
Reopening for more troubleshooting-in-public, not something I actually recommend. Nothing to see here folks... |
|
Well, that didn't work, guess I pushed before re-opening or something, on well... |
4 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change