test: modernized JS and tighten equality checking in test-eval.js #8590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed var -> const and assert.equal -> assert.strictEqual
Contributor
|
LGTM with a comment. |
cjihrig
reviewed
Sep 17, 2016
test/parallel/test-eval.js
Outdated
Contributor
There was a problem hiding this comment.
Can you line up the first single quote with the one on the line above it.
targos
reviewed
Sep 17, 2016
Wrapped line longer than 80 chars to more lines.
Contributor
Author
|
Fixed. |
targos
approved these changes
Sep 17, 2016
Member
Contributor
Author
|
Weird CI failure, actually the same as in #8618 Can you try to re-run the tests? |
Member
|
@wzoom the only failure (test/arm-fanned) is known to be flaky and is not related to this change. |
jasnell
pushed a commit
that referenced
this pull request
Sep 22, 2016
Changed var -> const and assert.equal -> assert.strictEqual PR-URL: #8590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in 070efb5. Thank you! |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
Changed var -> const and assert.equal -> assert.strictEqual PR-URL: #8590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Changed var -> const and assert.equal -> assert.strictEqual PR-URL: #8590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Changed var -> const and assert.equal -> assert.strictEqual
Cleanup according to nodejs/code-and-learn#56