Skip to content

Conversation

@alistairjcbrown
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

util

Description of change

Update inspect utility to support readable output of SharedArrayBuffer object. SharedArrayBuffer is available behind the harmony_sharedarraybuffer v8 flag. See the MDN docs for more details on what a SharedArrayBuffer is.

Update inspect utility to support readable output of SharedArrayBuffer
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. labels Sep 17, 2016
@yosuke-furukawa
Copy link
Member

I think that would be better to merge my fix... #8587

@Fishrock123
Copy link
Contributor

Shouldn't we wait for this feature to become publicly available in V8 first?

@alistairjcbrown
Copy link
Author

Looks like #8587 has been updated to be nearly the same as this PR (I've added comments on that PR).

The only thing this PR has extra is an update to a comment in test-util-inspect-simd.js to reference the correct test file, and adding an explicit ArrayBuffer test to test-util-inspect.js. I'll leave it open for the meantime, but it can probably be closed as a dupe.

@jasnell
Copy link
Member

jasnell commented Sep 20, 2016

For the time being I'll mark this as being blocked on #8587. Thank you!

@jasnell jasnell added the blocked PRs that are blocked by other issues or PRs. label Sep 20, 2016
@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
@jasnell jasnell removed the blocked PRs that are blocked by other issues or PRs. label Mar 1, 2017
@jasnell
Copy link
Member

jasnell commented Mar 1, 2017

Is this still needed?

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 1, 2017
@TimothyGu
Copy link
Member

Looks like everything except for the inspection test for ArrayBuffer was landed in #8587. Support for SIMD.js was deleted from util.format(). Closing this.

@TimothyGu TimothyGu closed this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. stalled Issues and PRs that are stalled. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants