Skip to content

test: remove FIXME pummel/test-tls-securepair-client #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ALJCepeda wants to merge 1 commit into from
Closed

test: remove FIXME pummel/test-tls-securepair-client #8757

ALJCepeda wants to merge 1 commit into from

Conversation

@ALJCepeda
Copy link
Contributor

@ALJCepeda ALJCepeda commented Sep 24, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Reverts: 85827bd
Refs: #4640
Using common.PORT no longer causes other tests to fail

Currently running make -j4 test returns errors for parallel/test-internal-modules and parallel/test-repl but that seems to be unrelated to this pull request.
It seems that there's something unusual going on with the VM I use to build

@ALJCepeda
test: remove FIXME pummel/test-tls-securepair-client
c6ed3e6 
Reverts: 85827bd
Refs: nodejs#4640
Using `common.PORT` no longer causes other tests to fail
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 24, 2016
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Sep 24, 2016
@lpinca
Copy link
Member

lpinca commented Sep 25, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4274/

@lpinca
Copy link
Member

lpinca commented Sep 25, 2016

LGTM if CI is green.

@ALJCepeda
Copy link
Contributor Author

ALJCepeda commented Sep 26, 2016 •
edited
Loading

It seems that most of the builds are failing https://ci.nodejs.org/job/node-test-pull-request/ maybe infrastructure issues still?

@imyller
Copy link
Member

imyller commented Sep 26, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4296/

@Trott
Copy link
Member

Trott commented Sep 27, 2016

Note that pummel tests are not run in CI, so the CI is basically only valuable for the linting in this case.

Test seems to work as expected with the change, so LGTM.

/cc @bnoordhuis

imyller
imyller approved these changes Oct 2, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Test works as expected

@jasnell
Copy link
Member

jasnell commented Oct 6, 2016

LGTM

@jasnell jasnell self-assigned this Oct 6, 2016
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@ALJCepeda @jasnell
test: remove FIXME pummel/test-tls-securepair-client
647e8e5 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 6, 2016

Landed in 647e8e5

@jasnell jasnell closed this Oct 6, 2016
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@ALJCepeda @jasnell
test: remove FIXME pummel/test-tls-securepair-client
13b4687 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@ALJCepeda @Fishrock123
test: remove FIXME pummel/test-tls-securepair-client
b579fca 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@ALJCepeda
test: remove FIXME pummel/test-tls-securepair-client
a2621a2 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@imyller imyller imyller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jasnell jasnell

Labels

test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ALJCepeda @lpinca @imyller @Trott @jasnell @mscdex @MylesBorins @nodejs-github-bot