Skip to content

benchmark: add eventEmitter.once() benchmarks #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscdex wants to merge 1 commit into from
Closed

benchmark: add eventEmitter.once() benchmarks #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions benchmark/events/ee-add-once.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
var common = require('../common.js');
var events = require('events');

var bench = common.createBenchmark(main, {n: [25e4]});

function main(conf) {
var n = conf.n | 0;

var ee = new events.EventEmitter();
var listeners = [];

for (var k = 0; k < 10; k += 1)
listeners.push(function() {});

ee.setMaxListeners(n * 10);

bench.start();
for (var i = 0; i < n; i += 1) {
for (var k = listeners.length; --k >= 0; /* empty */)
ee.once('dummy', listeners[k]);
}
bench.end(n);
}
0 benchmark/events/ee-add-remove.js → benchmark/events/ee-add-remove-on.js
View file
Open in desktop
File renamed without changes.
23 changes: 23 additions & 0 deletions benchmark/events/ee-emit-mixed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [2e6]});

function main(conf) {
var n = conf.n | 0;

var ee = new EventEmitter();

for (var k = 0; k < 10; k += 1) {
if (k % 2)
ee.once('dummy', function() {});
else
ee.on('dummy', function() {});
}

bench.start();
for (var i = 0; i < n; i += 1) {
ee.emit('dummy');
Copy link
Contributor

@brendanashworth brendanashworth Feb 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a very fair benchmark? after all, wouldn't any run after the first run be only to the .on() listeners?

Copy link
Contributor Author

@mscdex mscdex Feb 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you suggest?

Copy link
Contributor

@brendanashworth brendanashworth Feb 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just throwing ideas at the wall, but i'm thinking some sort of Object.freeze() (maybe deep-freeze) on the event emitter, which would (in non-strict mode) i believe silently fail when it is changed, leaving us the same object in each loop - thats the only idea that comes to mind that would only benchmark the .emit(), what do you think?

Copy link
Contributor

@brendanashworth brendanashworth Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do const objects behave, would that do the job?

}
bench.end(n);
}
24 changes: 24 additions & 0 deletions benchmark/events/ee-emit-multi-args-mixed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [2e6]});

function main(conf) {
var n = conf.n | 0;

var ee = new EventEmitter();
var listeners = [];

for (var k = 0; k < 10; k += 1) {
if (k % 2)
ee.once('dummy', function() {});
else
ee.on('dummy', function() {});
}

bench.start();
for (var i = 0; i < n; i += 1) {
ee.emit('dummy', 5, true);
}
bench.end(n);
}
0 benchmark/events/ee-emit-multi-args.js → benchmark/events/ee-emit-multi-args-on.js
View file
Open in desktop
File renamed without changes.
20 changes: 20 additions & 0 deletions benchmark/events/ee-emit-multi-args-once.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [2e6]});

function main(conf) {
var n = conf.n | 0;

var ee = new EventEmitter();
var listeners = [];

for (var k = 0; k < 10; k += 1)
ee.once('dummy', function() {});

bench.start();
for (var i = 0; i < n; i += 1) {
ee.emit('dummy', 5, true);
}
bench.end(n);
}
0 benchmark/events/ee-emit.js → benchmark/events/ee-emit-on.js
View file
Open in desktop
File renamed without changes.
20 changes: 20 additions & 0 deletions benchmark/events/ee-emit-once.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
var common = require('../common.js');
//var EventEmitter = require('../../lib/events').EventEmitter;
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [2e7]});

function main(conf) {
var n = conf.n | 0;

var ee = new EventEmitter();

for (var k = 0; k < 10; k += 1)
ee.once('dummy', function() {});

bench.start();
for (var i = 0; i < n; i += 1) {
ee.emit('dummy');
}
bench.end(n);
}