Skip to content

test: Use strictEqual in test-tls-writewrap-leak #9666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ughitsaaron wants to merge 1 commit into from
Closed

test: Use strictEqual in test-tls-writewrap-leak #9666

ughitsaaron wants to merge 1 commit into from
+1 −1

Conversation

@ughitsaaron
Copy link
Contributor

@ughitsaaron ughitsaaron commented Nov 17, 2016 •
edited by thefourtheye
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

Description of change

Prefers strictEqual as mentioned #9626

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2016
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 17, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4871/

LGTM if CI is green

@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Nov 17, 2016
@targos targos self-assigned this Nov 19, 2016
targos pushed a commit to targos/node that referenced this pull request Nov 19, 2016
@ughitsaaron @targos
test: Use strictEqual in test-tls-writewrap-leak
f133c16 
PR-URL: nodejs#9666
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos
Copy link
Member

targos commented Nov 19, 2016

Landed in f133c16. Thanks!

@targos targos closed this Nov 19, 2016
@targos targos removed their assignment Nov 19, 2016
@ughitsaaron ughitsaaron deleted the prefer-strict-equal branch November 21, 2016 15:37
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@ughitsaaron @addaleax
test: Use strictEqual in test-tls-writewrap-leak
731a1fa 
PR-URL: #9666
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@ughitsaaron @addaleax
test: Use strictEqual in test-tls-writewrap-leak
3130414 
PR-URL: nodejs#9666
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@ughitsaaron @MylesBorins
test: Use strictEqual in test-tls-writewrap-leak
e849dd0 
PR-URL: #9666
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@ughitsaaron @MylesBorins
test: Use strictEqual in test-tls-writewrap-leak
82a82c3 
PR-URL: #9666
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@ughitsaaron @MylesBorins
test: Use strictEqual in test-tls-writewrap-leak
691452d 
PR-URL: #9666
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

+3 more reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.