http: remove stale timeout listeners #9831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantorrie
force-pushed
the
fix-leak-9268
branch
from
d51fb0c to
1effe5e
Compare
3 tasks
Fishrock123
added
the
memory
Contributor
|
@cjihrig @jasnell @evanlucas @bnoordhuis you all LGTM'd the alternative PR, is this one less favorable? |
bnoordhuis
approved these changes
Dec 8, 2016
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
I wasn't aware this PR existed. :-) It has the benefit of creating fewer closures. That's never a bad thing.
Contributor
|
@evantorrie can you rebase this off of current master? Thanks! |
jasnell
approved these changes
Dec 22, 2016
Member
|
#9440 landed. Closing this without landing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
http
Description of change
Fix memory leak #9268 introduced by ee7af01
Unifies handling of timeout set via http#request (i.e. prior to socket connect) with explicit
ClientRequest.prototype.setTimeout. Previously,setTimeoutwould only apply if socket was writeable. Now, the timeout is applied regardless of whether socket is writeable, i.e. it applies to connect + write + read response combined.Alternative solution to #9440