-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
deps: upgrade npm to 2.6.1 #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
da730c7 partially reverted one of the floating patches. I think that means there are now 3 :-/ |
|
@cjihrig That's fine – if somebody can provide me a list of SHAs, I'm happy to cherry-pick them onto the PR and verify that the npm build still works. |
|
Can't we just squash the patches down and link to the originals? |
|
What I would prefer is to get a new version of |
|
I agree that fixing the problem in |
|
@cjihrig may be nice / better to link to the original commits, rather than the PR's. :) |
|
@cjihrig Can I suggest you link to the original commits in the commit log? Apart from that LGTM if installing and building still works. Land at will. |
|
🎉 |
This is a comparatively modest update, at least compared to
npm@2.7.0, which includes at least one feature that is very relevant to io.js's interests (foreshadowing!). Here are the pertinent changes innpm@2.6.1:8b98f0e#4471
npm outdated(and onlynpm outdated) now defaults to--depth=0. This also has the excellent but unexpected effect of makingnpm update -gwork the way almost everyone wants it to. See the docs for--depthfor the mildly confusing details. (@smikes)
aa79194#6565 Tweak
peerDependencydeprecation warning to include which peer dependency on which package is
going to need to change. (@othiym23)
5fa067f#7171 Tweak
engineStrictdeprecation warning to include which
package.jsonis using it.(@othiym23)
@bnoordhuis, do the floating patches for
node-gypstill need to be applied, or did da730c7 take care of one or both of them? I was unclear on this, so held off on applying them.