-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Better structure for guides' overview page #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So far guides appeared in random order which makes it hard to find your way around. This change groups related guides. Because of that it also disables the prev/next navigation (as order doesn't match any longer). Also fixed some little nits. Ref: nodejs/help#1122
|
|
||
| # 가이드 | ||
|
|
||
| ## General |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to leave this change up to the localization teams so they can pick language-appropriate titles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this change to land and let the Korean language team create a follow-up PR for the new headlines.
/cc @nodejs/nodejs-ko
| {{{ contents }}} | ||
|
|
||
| {{> prev-next-navigation }} | ||
| {{!> prev-next-navigation }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would impact reference doc pages too. We probably shouldn't use this layout for guides and leave this line the way it was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What reference doc pages are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry. I misread. It'd probably be good to be able to keep the continuation feature though. Perhaps we should consider putting the guides in sub-folders and number-prefix them to keep some sort of order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that as well but decided against it (for now):
- The order and categories I chose are quite arbitrary, there's no "right" flow
- This would also change URLs and we'd need to setup redirects
This section will be changed anyway in the relaunch we're currently working on, so it's a temporary fix anyway.
So far guides appeared in random order which makes it hard to find
your way around. This change groups related guides. Because of that it also
disables the prev/next navigation (as order doesn't match any longer).
Also fixed some little nits.
Ref: nodejs/help#1122