Skip to content

Conversation

@fhemberger
Copy link
Contributor

So far guides appeared in random order which makes it hard to find
your way around. This change groups related guides. Because of that it also
disables the prev/next navigation (as order doesn't match any longer).
Also fixed some little nits.

Ref: nodejs/help#1122

So far guides appeared in random order which makes it hard to find
your way around. This change groups related guides. Because of that it also
disables the prev/next navigation (as order doesn't match any longer).
Also fixed some little nits.

Ref: nodejs/help#1122

# 가이드

## General
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to leave this change up to the localization teams so they can pick language-appropriate titles.

Copy link
Contributor Author

@fhemberger fhemberger Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this change to land and let the Korean language team create a follow-up PR for the new headlines.

/cc @nodejs/nodejs-ko

{{{ contents }}}

{{> prev-next-navigation }}
{{!> prev-next-navigation }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would impact reference doc pages too. We probably shouldn't use this layout for guides and leave this line the way it was.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What reference doc pages are you referring to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. I misread. It'd probably be good to be able to keep the continuation feature though. Perhaps we should consider putting the guides in sub-folders and number-prefix them to keep some sort of order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that as well but decided against it (for now):

  • The order and categories I chose are quite arbitrary, there's no "right" flow
  • This would also change URLs and we'd need to setup redirects

This section will be changed anyway in the relaunch we're currently working on, so it's a temporary fix anyway.

@fhemberger fhemberger merged commit 7151347 into master Mar 8, 2018
@fhemberger fhemberger deleted the fix/sotructure-guides-overview branch March 8, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants