Skip to content

Conversation

@suensummit
Copy link
Contributor

Ref #1859

@ghost ghost requested a review from osk2 October 26, 2018 22:59
@osk2 osk2 merged commit 83515a0 into nodejs:master Oct 27, 2018
@ghost
Copy link

ghost commented Oct 27, 2018

@osk2:I feel very interested and strange:Since this is a PR by suensummit, so how can you do a direct submit following his? Don't you need to create a new PR, or github has the new function?!

@osk2
Copy link
Contributor

osk2 commented Oct 27, 2018 via email

@ghost
Copy link

ghost commented Oct 28, 2018

@osk2

Do u mean:

  1. Use "git remote add" to add suensummit's remote url origin.
  2. Then git push to his?

You can do submits to other man's proj without being allowed? 😮

@osk2
Copy link
Contributor

osk2 commented Oct 28, 2018 via email

@ghost
Copy link

ghost commented Oct 28, 2018

Thanks!

@suensummit suensummit deleted the feature/calendar-zh-tw branch October 28, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants