-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Update node-meetups.md #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node-meetups.md #2005
Conversation
Thanks for reviewing, will update :) Co-Authored-By: SofiEstevez <30813859+SofiEstevez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
ZYSzys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the format should be:
### Country(like United States)
#### State(like California)
##### City(like San Francisco)
| - If you do not currently have a CoC, update the meetup with CoC before submitting. | ||
| - Submit your PR in alphabetical order. | ||
|
|
||
| ## Meetups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder why this line was deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought maybe it was obvious but no worries, will add again!
|
@SofiEstevez:Maybe you can solve the conflicting files and push a submit, and we'll merge them. |
|
@Maledong Thank you, I just resolved conflicts :) |
|
@ZYSzys are we good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we'll merge this once suggestions below landed.(if my suggestions below are not wrong) :)
Co-Authored-By: SofiEstevez <30813859+SofiEstevez@users.noreply.github.com>
Sure, thank you for helping me formatting this! Co-Authored-By: SofiEstevez <30813859+SofiEstevez@users.noreply.github.com>
|
Hi @SofiEstevez , I'm a bit of curoious why you delete some |
|
@ZYSzys oh sorry, I just realized I prefer to don't assume these people want to share their info. |
|
Thank you !👍 |
Added a lot of meetups around the world :)