Skip to content

Conversation

@khaosdoctor
Copy link
Member

@khaosdoctor khaosdoctor commented Jun 16, 2019

Halfly finish the translation of PT_BR for Docs/Guides.

Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you for you contribution @khaosdoctor

@glaucia86
Copy link
Contributor

cc: @Maledong @Trott approved it this translation pt-br

@khaosdoctor
Copy link
Member Author

I think it is better to convert this as a draft again, so I can finish all the files in this section. This way I don't need to update the issue for every new translated file :D

@khaosdoctor khaosdoctor changed the title Translation: abi_stability 100% to pt-br [1/10] 3.1 Section: Docs/Guides -> pt_BR Jun 19, 2019
khaosdoctor and others added 2 commits June 21, 2019 10:25
Co-Authored-By: Tiago Danin <TiagoDanin@outlook.com>
Co-Authored-By: Tiago Danin <TiagoDanin@outlook.com>
@SEWeiTung
Copy link
Contributor

@khaosdoctor :I've added "on hold" label for you and when all of yours are finished, please tell me and I'll merge this and remove this label :)

@khaosdoctor khaosdoctor changed the title [1/10] 3.1 Section: Docs/Guides -> pt_BR [2/10] 3.1 Section: Docs/Guides -> pt_BR Jul 3, 2019
@Aissaoui-Ahmed Aissaoui-Ahmed added the i18n Issues/PRs related to the Website Internationalisation label Jul 21, 2019
@Aissaoui-Ahmed Aissaoui-Ahmed changed the title [2/10] 3.1 Section: Docs/Guides -> pt_BR PT_BR [2/10] 3.1 Section: Docs/Guides Jul 21, 2019
@khaosdoctor
Copy link
Member Author

Ahn, I think there are some MD linter rules broken in some pre-existing files. But some rules like this one:
image

Cannot be applied since the list actually continues on with the same matter:
image

@SEWeiTung
Copy link
Contributor

@khaosdoctor
I've sent you a private letter about what I've changed for you through your email address in the GitHub, you can directly use them to fix these bugs. Please DO NOT forget to take the latest codes and do your patches, and don't forget to run npm run test:lint before your submit ;)

@khaosdoctor khaosdoctor changed the title PT_BR [2/10] 3.1 Section: Docs/Guides PT_BR [4/10] 3.1 Section: Docs/Guides Sep 5, 2019
@SEWeiTung SEWeiTung changed the title PT_BR [4/10] 3.1 Section: Docs/Guides PT_BR: Docs/Guides Sep 6, 2019
@SEWeiTung SEWeiTung merged commit bd8155a into nodejs:master Sep 6, 2019
@SEWeiTung SEWeiTung removed the on hold label Sep 6, 2019
@SEWeiTung
Copy link
Contributor

@khaosdoctor , Since this has lasted for a long time, I have to merge it and you can submit another PR for your continue work of translation ;)

@khaosdoctor
Copy link
Member Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants