Skip to content

Conversation

@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 3, 2019

No description provided.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 3, 2019

We are getting close with this PR.

To make review easier, check the rich diff.

@nschonni
Copy link
Member

nschonni commented Sep 4, 2019

Might be able to remove some of the allowed_elements in MD033, but maybe you're waiting for the conversions to be finished first

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 4, 2019

Actually only one post is left AFAICT, but yeah, the next step is to adapt MD033.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 4, 2019

BTW this fixes many cases of wrong generated HTML. Someone had mixed Markdown into HTML which didn't work. This fixes the cases I hit, there are probably even more.

We need #2466 for sure.

@SEWeiTung
Copy link
Contributor

@XhmikosR, maybe you can forcely push because there're some conflicts with your changes ;)

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 5, 2019

@MaledongGit done

@Trott Trott merged commit c7bbe88 into nodejs:master Sep 5, 2019
@XhmikosR XhmikosR deleted the master-xmr-markdownify-2 branch September 6, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants