fix: remark-lint unordered-list-marker-style rule #2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
commented
Oct 14, 2019
nschonni
force-pushed
the
fix--remark-lint-unordered-list-marker-style-rule
branch
from
c4f44a0 to
abe3d29
Compare
XhmikosR
reviewed
Oct 14, 2019
XhmikosR
reviewed
Oct 14, 2019
locale/en/blog/vulnerability/v8-memory-corruption-stack-overflow.md
Outdated
Show resolved
Hide resolved
XhmikosR
reviewed
Oct 14, 2019
nschonni
force-pushed
the
fix--remark-lint-unordered-list-marker-style-rule
branch
from
abe3d29 to
783c8bc
Compare
Contributor
|
Also, please add the markdownlint rule; even if we replace markdownlint with remark-lint, this should be there. https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md004---unordered-list-style |
Switch to asterisks style to match upstream
nschonni
force-pushed
the
fix--remark-lint-unordered-list-marker-style-rule
branch
from
783c8bc to
1e9e364
Compare
XhmikosR
reviewed
Oct 14, 2019
XhmikosR
approved these changes
Oct 15, 2019
Trott
reviewed
Oct 15, 2019
Trott
reviewed
Oct 15, 2019
Contributor
|
I already reverted those @Trott |
aymen94
approved these changes
Oct 16, 2019
nschonni
deleted the
fix--remark-lint-unordered-list-marker-style-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to asterisks style to match upstream