feat: introduced json file for redirects #5615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
Contributor
📦 Next.js Bundle Analysis for nodejs.orgThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
bmuenzenmeyer
approved these changes
Aug 9, 2023
Contributor
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
didnt run the code locally but it looks like a smart change
@ovflowd who do you want to document this? I ask because you tagged me
Member
Author
I tagged you kinda to ask if you'd like (and have time) to document this, because I am also pretty overwhelmed with work right now 😢 |
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
ovflowd
force-pushed
the
feat/json-file-for-redirects
branch
from
69f43d7 to
29173ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies contribution to the external redirects and internal rewrites by adopting a no-code solution through a JSON file. This JSON file allows contributors to simply add and remove new entries on a JSON file which is easier to read and understand.
If the JSONs are invalid Next.js Build will fail, as a validation step. It is important to add a follow-up PR with docs updates and explaining these redirects/rewrites (pointing to Next.js documentation) (cc @bmuenzenmeyer)
Note: This PR also has a little off-topic change that is removing "wildcard" imports from common
.mjspublic-facing modulesValidation
Existing Redirects and Rewrites should still work