Skip to content

Conversation

@AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Feb 17, 2024

Description

Adding icon + link to category page of blog

Validation

it's should be same as figma design

Related Issues

Related to #5477

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • NA I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner February 17, 2024 17:19
@vercel
Copy link

vercel bot commented Feb 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 8:18pm

@bmuenzenmeyer
Copy link
Contributor

bmuenzenmeyer commented Feb 17, 2024

@AugustinMauroy thanks for working on this. while I agree it matches what the figma shows

@AugustinMauroy AugustinMauroy added design website redesign Issue/PR part of the Node.js Website Redesign github_actions:pull-request Trigger Pull Request Checks labels Feb 17, 2024
@github-actions github-actions bot removed github_actions:pull-request Trigger Pull Request Checks labels Feb 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 99 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/blog 🟢 100 🟢 98 🟠 83 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
86.43% (414/479) 77.43% (127/164) 78.02% (71/91)

Unit Test Report

Tests Skipped Failures Errors Time
76 0 💤 0 ❌ 0 🔥 4.753s ⏱️

Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
@ovflowd
Copy link
Member

ovflowd commented Feb 19, 2024

FYI I've fixed on main the blog category layout not respecting mobile width's

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my last comment, LGTM! ✨

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 19, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 19, 2024
@ovflowd ovflowd enabled auto-merge February 19, 2024 20:23
@ovflowd ovflowd added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit 6dffd14 Feb 19, 2024
@ovflowd ovflowd deleted the feat(rss)-visible-link branch February 19, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design website redesign Issue/PR part of the Node.js Website Redesign

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add visible link to RSS Feed

4 participants