-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add gzip task for production, fixes #712 #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That was quick! LGTM (haven't tested but flags and formats looks good to me); here are the content types we (would) gzip, so it should match well: |
|
@jbergstroem You don't gzip |
|
@fhemberger from nginx manual: "Responses with the “text/html” type are always compressed." |
|
@jbergstroem Ah, ok. Merging this now. |
|
Cool. Does this mean that it'll be shipped with next version of docs/website? |
|
I guess all that's left to do is replacing the line here (https://github.com/nodejs/build/blob/master/setup/www/resources/scripts/build-site.sh#L28): - build_cmd="npm run build"
+ build_cmd="npm run build; npm run gzip" |
|
Ok. Want to PR? |
Ref: #712
/cc @jbergstroem