Skip to content

Conversation

@Andrulko
Copy link
Contributor

Description

A small change to the configuration file related to Crowdin-GitHub connector to ensure that all files are processed as plain text file. I noticed that one file (docker.bash) was detected as Play Framework file - it won't allow to make comments translatable within the file

Validation

The change was tested locally, it works well. Note that you probably need to delete docker.bash from Crowdin project to re-apply new type)

Related Issues

No issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Andriy Poznakhovskyy <andriy@crowdin.com>
@Andrulko Andrulko requested a review from a team as a code owner December 23, 2024 08:20
@vercel
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 23, 2024 8:22am

@AugustinMauroy
Copy link
Member

Cc @ovflowd

@ovflowd
Copy link
Member

ovflowd commented Dec 23, 2024

Thank you!!

@ovflowd ovflowd merged commit 71f9a5f into nodejs:feat/snippet-generator Dec 23, 2024
1 check passed
ovflowd pushed a commit that referenced this pull request Dec 24, 2024
ovflowd added a commit that referenced this pull request Dec 24, 2024
* feat: download snippet generation

* feat: changed approach

* chore: simplify and reduce bundle size

* chore: reduce bundle

* chore: minor code fixes

* chore: more code review

* feat: introduced skeleton and animation

* chore: synchronous shiki

* chore: prevent internal errors

* chore: attempt to handle null situations

* fix: attempt to fix vercel env

* fix: erroneous env usage for fetch

* chore: fix select styles

* chore: updated allowlist for env vars

* feat: streamline detectos (only run query once)

* fix: avatar rendering and avatar group margins

* fix: pass ref

* chore: optimized release provider memo

* chore: next-image mock

* Update crowdin.yml (#7353)

* chore: improved loading state

* Apply suggestions from code review

Co-authored-by: Caner Akdas <canerakdas@gmail.com>
Signed-off-by: Claudio W <cwunder@gnome.org>

* chore: correct fixes

* fix: unit tests

* chore: final code review

* fix: server component test

* fix: rsc still risky for storybook

---------

Signed-off-by: Claudio W <cwunder@gnome.org>
Co-authored-by: Andriy Poznakhovskyy <andriy@crowdin.com>
Co-authored-by: Caner Akdas <canerakdas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants