feat: icons with versions #7962

ovflowd · 2025-07-08T15:46:22Z

This PR adds nice badges to the home page with current versions and link to blog posts, which are the same as the changelog.

Closes #7889

vercel · 2025-07-08T15:46:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jul 9, 2025 4:19pm

Copilot

Pull Request Overview

This PR adds versioned release badges to the home page and enables sizing for badge components.

Introduces a size prop to Badge and BadgeGroup with default "medium"
Updates CSS for badge message links to maintain consistent styling
Integrates BadgeGroup into MDX components and home page, and configures Turbo UI

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
turbo.json	Enable Turbo UI by setting `"ui": "tui"`
packages/ui-components/src/Common/BadgeGroup/index.tsx	Added `size` prop support and type reuse
packages/ui-components/src/Common/BadgeGroup/index.stories.tsx	Added `SmallDefault` story for badge sizes
packages/ui-components/src/Common/BadgeGroup/index.module.css	Extended `.message` selector for link styling
packages/ui-components/src/Common/Badge/index.tsx	Introduced `BadgeSize` alias for size strings
apps/site/pages/en/index.mdx	Render version badges on the home page
apps/site/next.mdx.use.mjs	Imported and exposed `BadgeGroup` to MDX

Comments suppressed due to low confidence (1)

packages/ui-components/src/Common/BadgeGroup/index.stories.tsx:17

[nitpick] We have a SmallDefault story for the default badge size, but no story demonstrating the warning or error variants at the small size. Adding those would ensure visual regression coverage for all size/variant combinations.

export const SmallDefault: Story = {

packages/ui-components/src/Common/BadgeGroup/index.module.css

codecov · 2025-07-08T15:47:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.74%. Comparing base (a459447) to head (17de69f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7962      +/-   ##
==========================================
+ Coverage   73.72%   73.74%   +0.02%     
==========================================
  Files          96       96              
  Lines        8365     8365              
  Branches      219      219              
==========================================
+ Hits         6167     6169       +2     
+ Misses       2197     2195       -2     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apps/site/pages/en/index.mdx

avivkeller · 2025-07-08T16:12:18Z

I'm not sure I love how it looks on Mobile. It feels like there is a lot of unused space

avivkeller · 2025-07-08T16:13:00Z

It's also not clear where these link to someone visiting the homepage

ovflowd · 2025-07-08T16:21:02Z

I'm not sure I love how it looks on Mobile. It feels like there is a lot of unused space

It looks good on mobile. It depends of your screen size. iPhone 12 looks good:

ovflowd · 2025-07-08T16:21:27Z

It's also not clear where these link to someone visiting the homepage

That is true. I'm wondering if we should even have links there 🤷

MattIPv4 · 2025-07-08T16:37:10Z

👀 I would probably expect the entire pill to be a link, not just the text?

ovflowd · 2025-07-08T17:02:04Z

not just the text?

You're right.

avivkeller · 2025-07-08T17:16:12Z

I'm not sure I love how it looks on Mobile. It feels like there is a lot of unused space

It looks good on mobile. It depends of your screen size. iPhone 12 looks good:

IMO if there isn’t enough space, each pill should be its own line.

turbo.json

apps/site/pages/en/index.mdx

ovflowd · 2025-07-08T21:33:30Z

IMO if there isn’t enough space, each pill should be its own line.

Done

ovflowd · 2025-07-08T21:33:47Z

cc @dario-piotrowicz playwright is failing for unknown reasons to me.

apps/site/pages/en/index.mdx

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org>

canerakdas

LGTM

ovflowd · 2025-07-09T14:09:49Z

I know we haven't reached 48 hours, would y'all be okay with fast-tracking? cc @nodejs/nodejs-website 👍 / 👎

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

dario-piotrowicz · 2025-07-09T16:40:25Z

cc @dario-piotrowicz playwright is failing for unknown reasons to me.

Sorry, I didn't see your ping earlier 😓

It seems like now it's all good right? 🙂

And regarding the failure (https://github.com/nodejs/nodejs.org/actions/runs/16154755332/job/45594542160#step:11:73), I am guessing that this was the bit causing the failure:

nodejs.org/apps/site/app/[locale]/next-data/api-data/route.ts

Line 37 in 2a5d26f

const mappedApiFiles = apiDocsFiles.map(

I wonder if this could have just been a github hiccup 🤔

feat: icons with versions

a3030e8

Copilot AI review requested due to automatic review settings July 8, 2025 15:46

ovflowd requested review from a team as code owners July 8, 2025 15:46

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025

ovflowd deployed to Storybook July 8, 2025 15:46 — with GitHub Actions View deployment

vercel bot deployed to Preview July 8, 2025 15:47 View deployment

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025

Copilot AI reviewed Jul 8, 2025

View reviewed changes

packages/ui-components/src/Common/BadgeGroup/index.module.css Show resolved Hide resolved

chore: no margin on mobile

da44924

vercel bot deployed to Preview July 8, 2025 15:50 View deployment

richardlau reviewed Jul 8, 2025

View reviewed changes

apps/site/pages/en/index.mdx Outdated Show resolved Hide resolved

ovflowd added 2 commits July 8, 2025 18:14

chore: lts explanation

cd2e074

fix: css hover for links on dark color not so different

ced0ab4

vercel bot deployed to Preview July 8, 2025 16:18 View deployment

chore: just tiny copyright

e4b2be7

vercel bot deployed to Preview July 8, 2025 16:24 View deployment

chore: use actual link

42e1fd0

vercel bot deployed to Preview July 8, 2025 17:04 View deployment

AugustinMauroy reviewed Jul 8, 2025

View reviewed changes

turbo.json Outdated Show resolved Hide resolved

avivkeller reviewed Jul 8, 2025

View reviewed changes

apps/site/pages/en/index.mdx Outdated Show resolved Hide resolved

vercel bot deployed to Preview July 8, 2025 21:29 View deployment

chore: by the honour of grayskull

8e00850

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025

ovflowd deployed to Storybook July 8, 2025 21:33 — with GitHub Actions View deployment

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025

vercel bot deployed to Preview July 8, 2025 21:34 View deployment

canerakdas reviewed Jul 9, 2025

View reviewed changes

apps/site/pages/en/index.mdx Outdated Show resolved Hide resolved

Update apps/site/pages/en/index.mdx

0ed8ef6

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org>

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 9, 2025

ovflowd deployed to Storybook July 9, 2025 13:35 — with GitHub Actions View deployment

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 9, 2025

vercel bot deployed to Preview July 9, 2025 13:36 View deployment

canerakdas approved these changes Jul 9, 2025

View reviewed changes

bmuenzenmeyer added this pull request to the merge queue Jul 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 9, 2025

Merge branch 'main' into feat/icons-with-versions

17de69f

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 9, 2025

ovflowd deployed to Storybook July 9, 2025 16:18 — with GitHub Actions View deployment

ovflowd enabled auto-merge July 9, 2025 16:18

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 9, 2025

vercel bot deployed to Preview July 9, 2025 16:19 View deployment

ovflowd added this pull request to the merge queue Jul 9, 2025

Merged via the queue into main with commit 2a5d26f Jul 9, 2025
17 checks passed

ovflowd deleted the feat/icons-with-versions branch July 9, 2025 16:26

avivkeller mentioned this pull request Jul 15, 2025

fix(release): fix issues with maintenance and active lts #7979

Merged

Uh oh!

feat: icons with versions #7962

feat: icons with versions #7962

Uh oh!

Conversation

ovflowd commented Jul 8, 2025

Uh oh!

vercel bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

codecov bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

avivkeller commented Jul 8, 2025

Uh oh!

avivkeller commented Jul 8, 2025

Uh oh!

ovflowd commented Jul 8, 2025

Uh oh!

ovflowd commented Jul 8, 2025

Uh oh!

MattIPv4 commented Jul 8, 2025

Uh oh!

ovflowd commented Jul 8, 2025

Uh oh!

avivkeller commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

ovflowd commented Jul 8, 2025

Uh oh!

ovflowd commented Jul 8, 2025

Uh oh!

Uh oh!

canerakdas left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Jul 9, 2025

Uh oh!

Uh oh!

dario-piotrowicz commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

vercel bot commented Jul 8, 2025 •

edited

Loading

codecov bot commented Jul 8, 2025 •

edited

Loading