-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: search modal overflow #8523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes overflow issues in the search modal by adding responsive width constraints and text truncation styles to the ui-components package. The changes ensure the search modal and its components render properly without overflow on various screen sizes.
- Added responsive max-width constraint to the search modal at medium breakpoint
- Implemented proper text truncation for search result descriptions
- Ensured tab list maintains proper width to prevent shrinking
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/src/Common/Search/Modal/index.module.css | Added md:max-w-[42rem] to constrain modal width on medium screens |
| packages/ui-components/src/Common/Search/Results/Hit/index.module.css | Added text truncation styles to hit descriptions and flex controls to prevent icon shrinking |
| packages/ui-components/src/Common/Search/Results/Tabs/index.module.css | Added w-max to prevent tabs from shrinking below content width |
| packages/ui-components/package.json | Bumped package version from 1.4.1 to 1.4.2 for the bug fix release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Make sure to resolve conflicts)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8523 +/- ##
==========================================
+ Coverage 74.65% 74.66% +0.01%
==========================================
Files 102 102
Lines 8956 8956
Branches 306 306
==========================================
+ Hits 6686 6687 +1
+ Misses 2268 2267 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Description
With this PR, we aim to move the customized search box styles currently used in
doc-kitinto the sharedui-componentspackage that we also use on the website, and to fix the overflow issue indoc-kitref: https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1767753183463229
Validation
The search box should be visible and fully usable in the preview without any issues.
Example expanded content;

Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.